Skip to content

fix: didn't work with goheader linter #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2023
Merged

fix: didn't work with goheader linter #25

merged 2 commits into from
Mar 26, 2023

Conversation

klesh
Copy link
Contributor

@klesh klesh commented Sep 24, 2022

The goheader linter requires the working directory to be project root in order to locate the header template correctly.

image

This PR fixes the problem and adds a mechanism to tolerate Unknown Errors by sending the detail to the client instead of crashing out.

Closes #24

@nametake nametake merged commit ec6d56b into nametake:master Mar 26, 2023
@thejan2009
Copy link
Contributor

Hey, this breaks golangci-lint-langserver for repositories where the go.mod is located in a subpath. Example structure:

project
├── .git
└── go
    ├── go.mod
    └── main.go

We always ran golangci-lint from project/go folder. How should this be fixed?

@thejan2009 thejan2009 mentioned this pull request Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linting error doesn't update when coding
3 participants
@klesh @thejan2009 @nametake